i was looking at getting an apple tv but do i get first or second gen
It depends on what kind of content you have, if you have a good network in your place of residence and how much you like using iTunes.
Frankly, IMO, the ATV 1 was more or less a POS. It was slow and suffered sync problems. The ATV 2 is a great piece of gear, if you have all of your content in iTunes (as I do). Fast, streamlined and well polished it will do what you want if you meet the above criteria. If not, then another option may be better for you.
For me, the ATV 2 is perfect with my HD TV, no setup issues, no problems with my relatively new TV.
Don't let the above nay sayers lead to believing that the ATV 2 isn't a good device. It is. In fact it's a great device.